added copying of static methods to resulting storeConnection component#8
Open
kellyrmilligan wants to merge 1 commit intoaltjs:masterfrom
Open
added copying of static methods to resulting storeConnection component#8kellyrmilligan wants to merge 1 commit intoaltjs:masterfrom
kellyrmilligan wants to merge 1 commit intoaltjs:masterfrom
Conversation
Author
|
hi there, thoughts on this? |
Author
|
? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will copy static methods defined on the component that is sent to connect to stores onto the resulting wrapped component. this is useful for when a route handler is defined for react-router that is wrapped by connectToStores. you can then access the static methods for fetching data, anything else.
had to update babel-eslint, eslintrc, etc to get linting to work.
created new tests for this feature.