Skip to content

Register paths with data manager in namespace serialization - #169

Open
Giubb8 wants to merge 1 commit into
alpha-unito:masterfrom
Giubb8:fix-serializers-commandpy
Open

Register paths with data manager in namespace serialization#169
Giubb8 wants to merge 1 commit into
alpha-unito:masterfrom
Giubb8:fix-serializers-commandpy

Conversation

@Giubb8

@Giubb8 Giubb8 commented May 19, 2025

Copy link
Copy Markdown

Register each output path for all scheduler locations in _deserialize_namespace so that outputs are discoverable by the data manager.

Before transferring inputs in _serialize_namespace, register the local source path (src_loc) with the data manager to ensure source files are tracked.

Register each output path for all scheduler locations in _deserialize_namespace so that outputs are discoverable by the data manager.

Before transferring inputs in _serialize_namespace, register the local source path (src_loc) with the data manager to ensure source files are tracked.
@codecov

codecov Bot commented May 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.40%. Comparing base (c2d9e0e) to head (50f28e0).
⚠️ Report is 64 commits behind head on master.

Files with missing lines Patch % Lines
jupyter_workflow/streamflow/command.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   70.45%   70.40%   -0.05%     
==========================================
  Files          21       21              
  Lines        1814     1818       +4     
  Branches      259      260       +1     
==========================================
+ Hits         1278     1280       +2     
- Misses        460      462       +2     
  Partials       76       76              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GlassOfWhiskey

Copy link
Copy Markdown
Member

Hi @Giubb8 ,
Thanks for contributing to Jupyter Workflow.
Can you add one or two tests that fail without your fix and pass after adding it, so that we can prevent regressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants