Conversation
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
decofe
requested review from
DaniPopes,
mattsse and
shekhirin
as code owners
September 18, 2026 10:00
decofe
marked this pull request as draft
September 18, 2026 10:12
mablr
reviewed
Sep 18, 2026
Comment on lines
+39
to
+41
| tool: cargo-codspeed@5.0.2 | ||
| checksum: true | ||
| fallback: cargo-binstall |
Contributor
There was a problem hiding this comment.
cargo-codspeed has no manifest in this pinned installer, so this always takes the cargo-binstall fallback https://github.com/tempoxyz/gh-actions/blob/25cce154e7fb10f99361a166468a6c56b9c31aa3/vendor/taiki-e/install-action/main.sh#L1093-L1107. checksum: true verifies the cargo-binstall bootstrap, but the fallback does not require a checksum/signature for the final tool binary. We should probably use an exact-version locked source install through Aegis, or add verified artifact support in gh-actions and disable fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Extend the Aegis rollout to all applicable workflows in this repository.
Solution
Initialize the same SHA-pinned secure runner as alloy#4203 before checkout and downloads, with job-scoped
id-token: write. Review all 3 workflow files and 9 job definitions.Run cargo-deny directly on the protected host instead of the reusable/container action, preserving all-features checks. Pin tool versions in the vendored installer and keep checksum verification enabled.
Validation and limits
YAML parsing, first-step/OIDC coverage assertions, and
git diff --checkpassed. Actionlint reports no new diagnostics compared with the default branch. Full platform execution and live policy enforcement remain subject to GitHub CI.The action configures Cargo, npm/pnpm/Yarn/Bun, Go, pip/uv/Poetry, and RubyGems/Bundler. Fork PRs without OIDC skip package enforcement with a warning. Cached artifacts, prebuilt tools, Docker images, OS packages, and direct binary downloads are not per-package policy checks. Existing dependency/lockfile policy is preserved.
Prepared with AI assistance.
Prompted by: @grandizzy