Fire OnLibraryAdded for extension libraries when plugins load.#2417
Open
bottiger1 wants to merge 1 commit intoalliedmodders:masterfrom
Open
Fire OnLibraryAdded for extension libraries when plugins load.#2417bottiger1 wants to merge 1 commit intoalliedmodders:masterfrom
bottiger1 wants to merge 1 commit intoalliedmodders:masterfrom
Conversation
Kenzzer
previously approved these changes
Mar 27, 2026
Member
Kenzzer
left a comment
Kenzzer
left a comment
There was a problem hiding this comment.
Seems sane to me, matches already existing logic for plugin-libs. But @KyleSanderson what are your thoughts on this, it seems you were against this in the original issue - are you still against it now ?
Contributor
|
This PR finaly resolves an issue that required a workaround for checking extension state.. |
Member
|
Following talks in #2170 I am dismissing my own review #2170 (comment) I'm now against the changes, unless consensus becomes that we're fine with extensions acting as 'plugins'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2170