Unnecessary check

src/common/models/splits/splits.ts

@@ -134,19 +134,13 @@ export class Splits extends Record<SplitsValue>(defaultSplits) {
         return split;
       }
       if (splitKind === "time") {
-        if (splitDimension.kind !== "time") {
-          throw new Error(`Expected Time Dimension, god ${splitDimension.kind}`);
-        }
         const clause = specificFilter.clauses.find(clause => clause instanceof FixedTimeFilterClause) as FixedTimeFilterClause;
         return split.changeBucket(clause
           ? getBestBucketUnitForRange(clause.values.first(), false, splitDimension.bucketedBy, splitDimension.granularities)
           : getDefaultGranularityForKind("time", splitDimension.bucketedBy, splitDimension.granularities)
         );
 
       } else if (splitKind === "number") {
-        if (splitDimension.kind !== "number") {
-          throw new Error(`Expected Number Dimension, god ${splitDimension.kind}`);
-        }
         const clause = specificFilter.clauses.find(clause => clause instanceof NumberFilterClause) as NumberFilterClause;
         return split.changeBucket(clause
           ? getBestBucketUnitForRange(clause.values.first(), false, splitDimension.bucketedBy, splitDimension.granularities)

src/common/utils/functional/functional.mocha.ts

@@ -259,7 +259,7 @@ describe("Functional utilities", () => {
 
     it("should return promise with value", async () => {
       const returnVal = 5;
-      const debounced = debounceWithPromise(() => returnVal, 10);
+      const debounced = debounceWithPromise(async () => returnVal, 10);
       const x = await debounced();
       expect(x).to.be.eq(returnVal);
     });