This repository was archived by the owner on Jun 26, 2026. It is now read-only.
support large ammount of datasources - #1012
Open
adrianmroz-allegro wants to merge 5 commits into
Open
Conversation
adrianmroz-allegro
marked this pull request as ready for review
January 9, 2023 10:35
size-limit report 📦
|
|
⏱️ Lighthouse report |
|
✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app |
|
⏱️ Lighthouse report |
|
✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app |
…usters and adding pagination to the `/sources/dataCubes`
adrianmroz-allegro
force-pushed
the
support-large-ammount-of-datasources
branch
from
January 9, 2023 12:46
a8a1136 to
f1f5854
Compare
|
⏱️ Lighthouse report |
|
✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app |
mkuthan
suggested changes
Jan 9, 2023
|
⏱️ Lighthouse report |
|
✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app |
mkuthan
approved these changes
Jan 10, 2023
mkuthan
left a comment
mkuthan
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for additional test scenarios!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/sources/dataCubes