Schema version visible in console - #2054
Open
faderskd wants to merge 12 commits into
Open
Conversation
✅ Benchmark comparison: PASSED
|
faderskd
marked this pull request as ready for review
August 17, 2026 12:27
michaldabrowski
approved these changes
Aug 17, 2026
| .map(SchemaVersion::value) | ||
| .toList(); | ||
| } catch (Exception exception) { | ||
| logger.error( |
Contributor
There was a problem hiding this comment.
warn? It is not critical for hermes to operate
especially if we fallback to empty list
| import java.util.List; | ||
| import pl.allegro.tech.hermes.api.TopicWithSchema; | ||
|
|
||
| public record TopicDetailsWithSchemaDetails( |
Contributor
There was a problem hiding this comment.
maybe TopicWithSchemaDetails?
| // when | ||
| WebTestClient.ResponseSpec response = | ||
| hermes.api().createTopic(new TopicWithSchema(topic, null)); | ||
| hermes.api().createTopic(TopicWithSchema.topicWithSchema(topic, null)); |
Contributor
There was a problem hiding this comment.
wondering if topicWithSchema method was not meant to be used as import static
TopicWithSchema.topicWithSchema sounds weird
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AVRO Topic:
JSON Topic:
