-
Notifications
You must be signed in to change notification settings - Fork 219
Updated gradle to 6.9.3 and optimized build process #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| org.gradle.jvmargs=-Xmx512m -XX:MaxPermSize=1024m | ||
| org.gradle.jvmargs=-Xmx512m -XX:MaxPermSize=1024m | ||
| org.gradle.parallel=true |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -43,22 +43,29 @@ dependencies { | |||||
| testCompile group: 'org.testcontainers', name: 'kafka', version: versions.testcontainers | ||||||
| } | ||||||
|
|
||||||
| def consoleDir = "${buildDir}/generated/console" | ||||||
|
|
||||||
| task buildHermesConsole(type: Exec) { | ||||||
| workingDir '../hermes-console' | ||||||
| def dir = '../hermes-console' | ||||||
| workingDir dir | ||||||
| outputs.dir(dir + "/dist") | ||||||
| inputs.dir(dir + "/static") | ||||||
| commandLine './package.sh' | ||||||
| } | ||||||
|
|
||||||
| task attachHermesConsole(type: Copy, dependsOn: 'buildHermesConsole') { | ||||||
| from '../hermes-console/dist/static' | ||||||
| into(sourceSets.main.output.resourcesDir.path + '/static') | ||||||
| } | ||||||
|
|
||||||
| tasks.register('prepareIndexTemplate') { | ||||||
| task attachHermesConsole(type: Copy) { | ||||||
| def targetDir = consoleDir | ||||||
| from tasks.named('buildHermesConsole') | ||||||
| into targetDir | ||||||
| include("static/**") | ||||||
| doLast { | ||||||
| def indexPath = sourceSets.main.output.resourcesDir.path + '/static/index.html' | ||||||
| ant.move file: indexPath, | ||||||
| tofile: indexPath + '.ftl' | ||||||
| ant.move file: targetDir + '/static/index.html', | ||||||
| tofile: targetDir + '/static/index.html.ftl' | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| jar.dependsOn(attachHermesConsole, 'prepareIndexTemplate') | ||||||
| sourceSets { | ||||||
| main { | ||||||
| resources.srcDir consoleDir | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can add the task provider here to automatically wire the task dependencies to ensure they are executed in the correct order
Suggested change
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this will break the current behaviour of the build as the static files are not attached to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah, i see. i suggested this with the assumption that all the outputs would be added. Do we still would need to make sure that the
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think not - |
||||||
| } | ||||||
| } | ||||||
Uh oh!
There was an error while loading. Please reload this page.