fix: make setup script cross-platform (fix #7182)#7185
Open
scrollDynasty wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the repository setup script cross-platform.
Previously,
pnpm run setupused the Unix-specific commandrm -rfto removenode_modules, which fails on Windows (PowerShell/CMD) and prevents Windows contributors from completing the setup flow.Changes
rm -rf node_moduleswith a dependency-free Node.js cleanup script using built-infsandpath.setupscript to use the cleanup script beforepnpm install.node_modulespnpm-lock.yaml.Why not rimraf?
rimrafwas considered since it is already used elsewhere in the repository. However, the setup script may run beforepnpm install, meaningnode_modulesbinaries (includingrimraf) may not exist in fresh clones.A small Node.js script avoids this bootstrap problem and works in all environments without prerequisites.
Verification
Tested on Windows PowerShell:
Result::
0node_modulesis missingpnpm run setupwas not executed due to its side effects (install, prebundle, build), but the cleanup step integrates without affecting the existing flow.Related: