fix: support cjs files in compileDependencies (fix #7181)#7183
Open
scrollDynasty wants to merge 1 commit into
Open
fix: support cjs files in compileDependencies (fix #7181)#7183scrollDynasty wants to merge 1 commit into
scrollDynasty wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
.cjssupport tocompileDependencies.The Problem
Previously,
.cjsdependency files were excluded from the compilation matching logic. As a result, packages resolving to.cjsentry points could ship modern syntax (like optional chaining) without being transpiled for older targets, causing runtime errors.Changes
.cjssupport: Included the extension in the dependency compilation matching logic..cjsfiles used throughcompileDependencies..js,.jsx,.ts,.tsx, and.mjs.Verification
Ran the targeted regression test suite:
pnpm exec vitest run packages/shared-config/tests/compileDependencies.test.tsResults:
Fixes 希望支持.cjs 扩展名的编译 #7181