Skip to content

Fix starrocks expression partition parse #6508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qingzheguo-flash wants to merge 3 commits into
base: master
Choose a base branch
from
+39 −17
Open

Fix starrocks expression partition parse #6508

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15e391c
fix starrocks expression partition;
qingzheguo-flash Aug 17, 2025
aaaa815
fix starrocks expression partition;
qingzheguo-flash Aug 17, 2025
e4fd1ab
fix code style
qingzheguo-flash Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .../main/java/com/alibaba/druid/sql/dialect/starrocks/parser/StarRocksCreateTableParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,19 +205,21 @@ public SQLPartitionBy parsePartitionBy() {
if (hasLparen) {
accept(Token.RPAREN);
}
accept(Token.LPAREN);
for (; ; ) {
if (lexer.token() == Token.RPAREN) {
if (lexer.token() == Token.LPAREN) {
Copy link
Copy Markdown
Member

@wenshao wenshao Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can use nextIf, like this:

if (lexer.nextIf(Token.LPAREN)) {
//We don't need to use accept here.
}

Copy link
Copy Markdown
Author

@qingzheguo-flash qingzheguo-flash Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, please take a look, thanks. @wenshao

accept(Token.LPAREN);
for (; ; ) {
if (lexer.token() == Token.RPAREN) {
break;
}
partitionClause.addPartition(this.getExprParser().parsePartition());
if (lexer.token() == Token.COMMA) {
lexer.nextToken();
continue;
}
break;
}
partitionClause.addPartition(this.getExprParser().parsePartition());
if (lexer.token() == Token.COMMA) {
lexer.nextToken();
continue;
}
break;
accept(Token.RPAREN);
}
accept(Token.RPAREN);
return partitionClause;
}
return null;
Expand Down
36 changes: 29 additions & 7 deletions ...t/java/com/alibaba/druid/sql/dialect/starrocks/parser/StarRocksCreateTableParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,15 @@ public class StarRocksCreateTableParserTest extends TestCase {
"DUPLICATE KEY (`recruit_date`, `region_num`)\n" +
"PARTITION BY RANGE(`recruit_date`)\n" +
"(\n" +
" PARTITION partition_name1 VALUES LESS THAN MAXVALUE | (\"value1\", \"value2\"), \n" +
" PARTITION partition_name2 VALUES LESS THAN MAXVALUE | (\"value1\", \"value2\")\n" +
" PARTITION partition_name1 VALUES LESS THAN (\"value1\"), \n" +
" PARTITION partition_name2 VALUES LESS THAN MAXVALUE\n" +
")\n" +
"DISTRIBUTED BY HASH(`recruit_date`, `region_num`) BUCKETS 8\n" +
"PROPERTIES (\n" +
"\t\"replication_num\" = \"1\"\n" +
")",

// // 4.分区类型为 Fixed Range的建表语句
// 4.分区类型为 Fixed Range的建表语句
"CREATE TABLE IF NOT EXISTS `detailDemo` (\n" +
"\t`recruit_date` DATE NOT NULL COMMENT 'YYYY-MM-DD',\n" +
"\t`region_num` TINYINT COMMENT 'range [-128, 127]',\n" +
Expand Down Expand Up @@ -166,12 +166,12 @@ public class StarRocksCreateTableParserTest extends TestCase {
")\n" +
"DISTRIBUTED BY HASH(`recruit_date`, `region_num`) BUCKETS 8\n" +
"PROPERTIES (\n" +
"\t\"storage_medium\" = \"[SSD|HDD]\",\n" +
"\t\"storage_medium\" = \"SSD\",\n" +
"\t\"dynamic_partition.enable\" = \"true|false\",\n" +
"\t\"dynamic_partition.time_unit\" = \"DAY|WEEK|MONTH\",\n" +
"\t\"dynamic_partition.start\" = \"${integer_value}\",\n" +
"\t[\"storage_cooldown_time\" = \"yyyy-MM-dd HH:mm:ss\",]\n" +
"\t[\"replication_num\" = \"3\"]\n" +
"\t\"storage_cooldown_time\" = \"yyyy-MM-dd HH:mm:ss\",\n" +
"\t\"replication_num\" = \"3\"\n" +
")",

// 7.含有 Bitmap 索引和聚合函数的建表语句
Expand Down Expand Up @@ -217,7 +217,29 @@ public class StarRocksCreateTableParserTest extends TestCase {
"\t\"in_memory\" = \"false\",\n" +
"\t\"storage_format\" = \"V2\",\n" +
"\t\"disable_auto_compaction\" = \"false\"\n" +
")"
")",

// 10. 表达式分区
"CREATE TABLE IF NOT EXISTS `detailDemo` (\n" +
"\t`recruit_date` DATE NOT NULL COMMENT 'YYYY-MM-DD',\n" +
"\t`region_num` TINYINT COMMENT 'range [-128, 127]',\n" +
"\t`num_plate` SMALLINT COMMENT 'range [-32768, 32767] ',\n" +
"\t`tel` INT COMMENT 'range [-2147483648, 2147483647]',\n" +
"\t`id` BIGINT COMMENT 'range [-2^63 + 1 ~ 2^63 - 1]',\n" +
"\t`password` LARGEINT COMMENT 'range [-2^127 + 1 ~ 2^127 - 1]',\n" +
"\t`name` CHAR(20) NOT NULL COMMENT 'range char(m),m in (1-255)',\n" +
"\t`profile` VARCHAR(500) NOT NULL COMMENT 'upper limit value 1048576 bytes',\n" +
"\t`hobby` STRING NOT NULL COMMENT 'upper limit value 65533 bytes',\n" +
"\t`leave_time` DATETIME COMMENT 'YYYY-MM-DD HH:MM:SS',\n" +
"\t`channel` FLOAT COMMENT '4 bytes',\n" +
"\t`income` DOUBLE COMMENT '8 bytes',\n" +
"\t`account` DECIMAL(12, 4) COMMENT '\"\"',\n" +
"\t`ispass` BOOLEAN COMMENT 'true/false'\n" +
") ENGINE = OLAP\n" +
"DUPLICATE KEY (`recruit_date`, `region_num`)\n" +
"PARTITION BY recruit_date, region_num \n" +
"DISTRIBUTED BY HASH(`recruit_date`, `region_num`) BUCKETS 8\n"

};


Expand Down