Repository navigation
fix: return null from TransformerManager when no transformer changes the class - #3285
Merged
hengyunabc merged 1 commit intoNov 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3283
The transformers that
TransformerManagerregisters returned the inputclassfileBufferwhen no transformer had changed the class. For a retransform-capable agent, HotSpot treats a non-null return as a modification and keeps a copy of the original class bytes (JvmtiClassFileLoadHookPoster::post_to_env), so every loaded class kept an extra copy in native memory. Both the retransform-capable and the lazy transformer now returnnullwhen nothing changed.Added
TransformerManagerTest. The three cases that expectnullfail without the change. I could not run thecoremodule build on Windows becausearthas-vmtoolneeds a native compile, so I ran the new test class against the same sources with JDK 21 and--release 8.