Repository navigation
feat: log cross-namespace attach success - #3259
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Propagates cross-mount-namespace attach metadata and records successful target JVM startup events.
Changes:
- Transmits detected attach mode through agent arguments.
- Logs structured cross-namespace startup details.
- Adds metadata and logging tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
core/.../Arthas.java |
Propagates detected namespace mode. |
core/.../Configure.java |
Adds internal namespace metadata. |
core/.../ArthasBootstrap.java |
Emits the structured success event. |
core/.../ConfigureTest.java |
Tests metadata transmission. |
core/.../ArthasBootstrapTest.java |
Tests conditional event logging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
108
to
111
| if (crossMountNamespace) { | ||
| configure.setCrossMountNamespace(true); | ||
| socketSymlink = exposeTargetAttachSocket(targetPid); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arthas.logafter the Arthas server has startedWhy
Follow-up to #3247. The attach-side success output and the target-side startup log currently look the same for normal and cross-mount-namespace attaches, so users cannot confirm which path succeeded.
After this change, a successful cross-namespace startup records:
Same-mount-namespace attaches do not emit this event.
Validation
./mvnw -pl core -am -Dtest=ConfigureTest,ArthasBootstrapTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl core -am test— 300 tests, 0 failures, 0 errors, 7 skippedgit diff --check