Skip to content

fix(cosh-ng): keep debug trap on bash 4.2 prompts #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kongche-jbw merged 1 commit into from
Aug 22, 2026
+7 −1
Merged

fix(cosh-ng): keep debug trap on bash 4.2 prompts #2757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cosh-ng/crates/cosh-shell/src/shell_host/marker/bash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,13 @@ _cosh_prompt_command() {
_cosh_precmd_marker "$status"
_cosh_run_user_prompt_command "$status"
_cosh_maybe_emit_native_history_file_marker
if [[ -n "${_COSH_USER_PROMPT_COMMAND+x}" ]]; then
# bash < 5 suspends the DEBUG trap while PROMPT_COMMAND runs (#2736):
Comment thread
jfeng18 marked this conversation as resolved.
# `trap -p DEBUG` prints nothing inside the hook, and the empty snapshot
# read would poison _COSH_ACTIVE_DEBUG_TRAP, permanently dropping the
# trap after the first command. Suspension guarantees the trap is
# untouched during the hook, so only bash >= 5 — where `trap -p DEBUG`
# stays truthful — needs the snapshot.
if (( BASH_VERSINFO[0] >= 5 )) && [[ -n "${_COSH_USER_PROMPT_COMMAND+x}" ]]; then
local trap_snapshot_file="${COSH_RECOVERY_REQUEST_FILE:-/tmp/cosh-recovery}.debug-trap"
_COSH_SNAPSHOT_DEBUG_TRAP=1
trap -p DEBUG > "$trap_snapshot_file" 2>/dev/null || true
Expand Down
Loading