fix(sight): match latency agents case-insensitively - #2590
Merged
chengshuyi merged 1 commit intoAug 17, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6762108f3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
yefuyou
force-pushed
the
fix/sight/latency-agent-identity
branch
from
August 16, 2026 07:21
6762108 to
797e246
Compare
Correct the latency Agent filter to align with existing case-insensitive Agent identity handling. Fixes: ba20d94 ("feat(agentsight): add LLM latency metrics API (alibaba#2578)")
yefuyou
force-pushed
the
fix/sight/latency-agent-identity
branch
from
August 16, 2026 13:05
797e246 to
f2dd889
Compare
chengshuyi
approved these changes
Aug 17, 2026
chengshuyi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. 核心逻辑正确,scope 干净。几点 minor suggestions 不阻塞合入:1) 同文件 get_token_timeseries/get_model_timeseries 仍为 case-sensitive,建议 follow-up 统一;2) ?3 COLLATE NOCASE 冗余可简化;3) 可补 process_name fallback 的 case-insensitive 测试。
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correctness follow-up to #2578, discovered during review of #2586.
The existing Agent Sessions UI treats casing variants such as
Qoderandqoderas the same Agent, but the latency API used a case-sensitive SQLite comparison. This could make the selected sessions match while/api/metrics/latencyreturned no rows.Changes
COLLATE NOCASEagent_namelabelprocess_namefallback semantics unchangedScope
This PR is limited to
src/agentsight/src/storage/sqlite/genai/stats.rs.It does not change:
Merge order
Recommended order: #2583 → this follow-up → #2586.
#2583 is preferred first because it addresses the existing AgentSight Clippy failures and also touches
stats.rs; it is not a hard dependency of this PR. #2586 has the functional dependency on this case-insensitive latency filtering.Validation
latency_tests: 9 passedcargo +1.89.0 fmt --all -- --checkgit diff --checkcargo testhas one unrelated existing doctest failure insrc/genai/helpers.rsclippy::let_and_returninsrc/agentsight/src/analyzer/unified.rsclippy::unnecessary_map_orinsrc/agentsight/src/storage/sqlite/genai/stats.rs