fix: use _sample_inspirations in sample_from_island for consistent inspiration selection#456
Open
octo-patch wants to merge 1 commit intoalgorithmicsuperintelligence:mainfrom
Conversation
…spiration selection (fixes algorithmicsuperintelligence#437)
|
octo-patch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
octo-patch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437
Problem
sample_from_island()selects inspiration programs using plainrandom.sample()from island program IDs, whilesample()delegates to the much richer_sample_inspirations()method. This inconsistency means that the parallel execution path (process_parallel.py→sample_from_island) misses:Solution
Replace the ad-hoc random sampling block in
sample_from_island()with a call to_sample_inspirations(parent, n=num_inspirations). Because_sample_inspirationsderives the target island fromparent.metadata["island"]— and the parent was sampled from the correct island — the method automatically scopes sampling to the right island, maintaining the same island isolation guarantee.Testing
python -m unittest discover tests)