CI: apply changes from latest modernize v0.39.0#6498
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6498 +/- ##
==========================================
- Coverage 47.59% 47.40% -0.19%
==========================================
Files 666 659 -7
Lines 88508 88423 -85
==========================================
- Hits 42123 41920 -203
- Misses 43618 43725 +107
- Partials 2767 2778 +11 ☔ View full report in Codecov by Sentry. |
jannotti
approved these changes
Nov 14, 2025
jannotti
left a comment
jannotti
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. I'd vote for not locking modernize until/unless updates get really annoying. I'd rather get updates this way than a bunch of annoying PRs by others who use it.
algorandskiy
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The latest version of modernize in golang.org/x/tools v0.39.0 provides some new checks that breaks the codegen_verification CI step without this PR. Uses algorand/msgp#35 to make modernize and linters happy with generated code too.
Test Plan
Comment-only changes