Repository navigation
evals: remove misleading timing metrics - #33
Merged
Merged
Conversation
These timings are misleading with concurrency control and retries — they measure queue wait and backoff time more than model performance. Token counts and attempts are better metrics. Keep StarlarkTime since it measures local execution with no retry noise. Co-authored-by: Shelley <shelley@exe.dev>
Co-authored-by: Shelley <shelley@exe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
DurationandLLMTimetracking from eval results — these are misleading with concurrency control and retries (they measure queue wait and backoff time more than model performance).Keep
StarlarkTimesince it measures local execution with no retry noise.Also simplify the live display: remove duration stats from finished/in-progress lines, reduce refresh rate to 2/s.
Token counts and attempt counts are better metrics for comparing models.