Simplify codebase, add CI, rename packages to crates - #2
Merged
Conversation
- Fix TOCTOU race in CircuitBreaker by replacing RwLock with Mutex - Add token-bucket RateLimiter with configurable rate and burst - Sanitize error messages to avoid leaking token existence info - Add GitHub Actions CI pipeline (fmt, clippy, test, build) - Add cargo-deny config for dependency auditing - Optimize routing with Arc-wrapped snapshots and arena-based BFS - Add rustdoc to public APIs - Add integration tests for end-to-end flows
alexanderattar
force-pushed
the
production-hardening
branch
from
January 8, 2026 03:58
a45d8e5 to
6fa44a6
Compare
- Rename packages/ to crates/ (idiomatic Rust structure) - Remove rust-toolchain.toml (was pinning to 1.82.0) - Remove CircuitBreaker (trips on normal business logic, not infrastructure failures) - Remove RateLimiter (no external clients to rate limit in simulation) - Rename BookMeta to OrderbookHealth with clearer field names - Add CLAUDE.md for AI tooling context - Update README with coverage instructions
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
alexanderattar
force-pushed
the
production-hardening
branch
from
January 15, 2026 21:55
29748f2 to
800c7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored codebase for clarity and removed over-engineering. Key changes:
last_updated,has_valid_spread) instead of vague ones (updated_at,healthy)packages/tocrates/to follow Rust conventionsWhat remains
The core architecture is unchanged:
scc::HashMapfor lock-free concurrent orderbook accessTest plan
cargo clippycleancargo fmt --checkpasses