feat: add WithVariableExpansion to expand in default struct tags#46
Merged
Merged
Conversation
alecthomas
reviewed
Feb 5, 2026
| } | ||
| } | ||
|
|
||
| func WithVariableExpansion(vars map[string]string) MarshalOption { |
| } | ||
|
|
||
| if opt != nil && opt.variableExpander != nil { | ||
| defaultValue = os.Expand(defaultValue, opt.variableExpander) |
Owner
There was a problem hiding this comment.
I don't think we want to use os.Expand as it locks us into the syntax supported by it. The option function should just take the whole default value and do whatever it needs to.
Author
There was a problem hiding this comment.
Is this what you are thinking?
func WithDefaultTransformer(transformer func(string) string) MarshalOption {
return func(options *marshalState) {
options.defaultTransformer = transformer
}
}
Then at the call site they can use os.Expand if they want?
alecthomas
approved these changes
Feb 5, 2026
Owner
|
Glorious! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, default values in struct tags are static strings. This PR adds
WithDefaultTransformermarshal option that provides complete flexibility for default value processing.