Repository navigation
Api compat - #24
Merged
Merged
Api compat#24
Conversation
FiscalClient.pkcs12_data now accepts raw PFX bytes, a base64 encoded certificate (the Odoo Binary field form, which nfelib's CommonMixin.sign_xml passes through erpbrasil.assinatura) or a file path, normalizing internally to raw bytes for the requests_pkcs12 adapter. The as-given value stays available as pkcs12_data for signing. This removes the need for callers to know which encoding each consumer expects (the fake_certificate split-brain the Odoo l10n_br_nfe nfelib POC had to work around).
nfelib's SOAP clients unwrap nfeResultMsg content into the wrapped response after the send (response.resposta = ...): the read-only property aliases broke them. Keep the new field names as canonical and make the erpbrasil.edoc-style aliases settable.
Contributor
|
Testando o |
Member
Author
|
Caramba eu achava que eu tivesse mesclado já, mesclando tá ok né? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📒 Description
compat layer, see commits
🛫 Checklist