fix: follow-up fixes for logo sync and filament spool_count#3
fix: follow-up fixes for logo sync and filament spool_count#3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 578f7daf6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Upstream ReferencesThis work builds on the filament label flow introduced in PR Donkie#846 and extends it with manufacturer-logo support and related UX improvements. Addresses / Advances Existing Upstream Requests
Relation to Earlier PR
|
51b49a3 to
0a7a235
Compare
|
Follow-up QA note:
I also cleaned up the PR description text so the fix bullets show the correct code references (for example, |
8b0be0f to
bfa9681
Compare
|
Branch cleanup complete:
Also updated PR description with an explicit upstream-linkage section so it is clear which changes map to upstream requests and which are UX hardening follow-ups. |
bfa9681 to
99ff9c2
Compare
Summary
Follow-up PR on top of merged fork work to harden logo sync behavior, spool-count handling, and UI consistency.
Fixes Included
refs/heads/<branch>.getAPIURL()for vendor logo sync calls in vendor edit so base-path deployments work.spool_countsorting/filtering 500s and optimize thespool_countquery path.spool.filament_idwith column-based duplicate detection to avoid redundant FK indexes.Validation
PYTHONPYCACHEPREFIX=/tmp/pycache python3 -m py_compile spoolman/vendor_logos.pyPYTHONPYCACHEPREFIX=/tmp/pycache python3 -m py_compile migrations/versions/2026_02_20_1605-b5f9c2e31a1b_add_index_on_spool_filament_id.pydocker run --rm -v "$PWD:/app" -w /app/client -e VITE_APIURL=/api/v1 -e NPM_CONFIG_CACHE=/tmp/.npm -e XDG_CONFIG_HOME=/tmp/.config -e HOME=/tmp node:20 /bin/bash -lc "npm ci && npm run build"Manual Checks
spool_countsorting/filtering works without 500s.