feat: adds db filter by persisted storage#3189
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR extends bid-screening aggregation and filtering to include persistent storage classes. The aggregator extracts and deduplicates storage class values from persistent volumes per unit, the repository filters candidates via JSONB containment on provider storage classes, and integration tests validate the full flow with enhanced test harness support. ChangesPersistent Storage Class Filtering for Bid Screening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes The changes follow an established per-unit aggregation pattern already present in GPU token logic. The new persistent storage token collector mirrors GPU token extraction but simpler (no vendor/model parsing, only class deduplication). Query clause addition is straightforward containment filtering. Test coverage is thorough but uses consistent existing patterns. No complex state management, concurrency, or security concerns. Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
==========================================
- Coverage 63.74% 62.98% -0.76%
==========================================
Files 1091 1050 -41
Lines 26479 25452 -1027
Branches 6422 6255 -167
==========================================
- Hits 16879 16031 -848
+ Misses 8402 8236 -166
+ Partials 1198 1185 -13
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
ref CON-344
What
Summary by CodeRabbit
Release Notes
Tests
Bug Fixes