Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everybody hates timezones
This replaces datetime.Instant with time.Instant since the former is deprecated. But there are two fixes that I should explain in more detail
Lets start with an extreme example
Kitshn: Tokyo UTC+9
Tandoor: Berlin UTC+2
Given a date like 2026-04-15T10:00:00+09:00 it would cut of the time and convert it to UTC i.e
send 2026-04-14T15:00:00Z in a round trip this would be converted back to UTC+9 again to 15.04.2026 again but in the server it 14.04.2026.
Although the time is "more" correct with the timezone since we strictly look at the date
We should always send back 2026-04-15T00:00:00+00:00 even for the example.
Maybe I am just thinking wrong