Skip to content

Proposed changes to recipe search & selection flow#375

Merged
aimok04 merged 7 commits intoaimok04:mainfrom
jonsch318:search-fix
Apr 18, 2026
Merged

Proposed changes to recipe search & selection flow#375
aimok04 merged 7 commits intoaimok04:mainfrom
jonsch318:search-fix

Conversation

@jonsch318
Copy link
Copy Markdown
Contributor

This is my proposal for a more unified consolidated recipe selection flow.

  1. Generalized the HomeSearchState & Content to RecipeSearchState / Content
  2. Implemented a new RecipeSearchDialog to serve as a base & has similar responsibilities to the HomeSearch -> HomeSearchTopBar
  3. Let SelectRecipeDialog use the RecipeSearchDialog. This could be discussed but I imaged the search dialog to be more generic to serve as a base
  4. Let RecipeSearchField use the SelectRecipeDialog.

The Dialog has it's own query state and does not interfere with the HomeSearchState

It also includes some fixes that if not approved i would do another pr for:

  1. Constant re-requests because of the onSearch property. Especially with the haptic feedback the phone would spam it sometimes
  2. Flickering on search because the items where removed on loading state.
  3. (not a bug per se) removed the loading animation on search with exception of prior empty results. This was to cluttered and short lived in my opinion.
  4. (not a bug per se) similar to 3. removed the haptic feedback since this was a bit to much from my opinion, easy to bring back in if wanted.

Now a few recording

output.mp4

@aimok04 aimok04 force-pushed the search-fix branch 2 times, most recently from 7c3b880 to e2aa5e2 Compare April 18, 2026 14:06
@aimok04
Copy link
Copy Markdown
Owner

aimok04 commented Apr 18, 2026

@jonsch318

Thanks, this is great!

I have done some changes:

  • I readded the loading animation, because I think it's better to have a loading indicator, especially for users with a slow server / bad connection. (But I agree that the haptic feedback is a bit over the top)
  • I have added the UnfoldMore icon like you did in Add meal type selection picker and dialog #386 to indicate that the field opens a dialog.
  • I have replaced Dialog with AdaptiveFullscreenDialog and did some adjustments, so that the dialog looks more in line with other dialogs:
Screenshot_20260418_154853

@aimok04 aimok04 merged commit 688c601 into aimok04:main Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants