fix: tolerate missing ResourceClaim API during PCLQ reconcile and delete#610
Open
SAY-5 wants to merge 1 commit into
Open
fix: tolerate missing ResourceClaim API during PCLQ reconcile and delete#610SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
SAY-5
requested review from
Ronkahn21,
danbar2,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
estroz
reviewed
May 13, 2026
| client.MatchingLabels(labels), | ||
| ); err != nil { | ||
| if meta.IsNoMatchError(err) { | ||
| return nil |
There was a problem hiding this comment.
It may be useful to debug log the error in case of misconfiguration
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix-resourceclaim-no-match
branch
from
185e4ad to
545d5ab
Compare
Author
|
Added a V(1) debug log on the swallowed NoMatchError in Delete with namespace, podClique, and err. Single-commit force push, +2/-1. |
gflarity
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
PodClique reconcile and delete now treat
meta.IsNoMatchErrorfrom ResourceClaim list/delete as "nothing to do" instead of a hard failure, so cleanup is not blocked on clusters that do not serve theresource.k8s.ioResourceClaim API.Which issue(s) this PR fixes:
Fixes #609
Special notes for your reviewer:
If the API is absent there can be no ResourceClaim objects to reconcile or delete, so skipping is safe. Added regression tests using an interceptor that returns
NoKindMatchError.Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: