docs(mnnvl): update GREP-417 to single-annotation model#568
Open
shmuel-runai wants to merge 4 commits into
Open
docs(mnnvl): update GREP-417 to single-annotation model#568shmuel-runai wants to merge 4 commits into
shmuel-runai wants to merge 4 commits into
Conversation
shmuel-runai
requested review from
Ronkahn21,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
danbar2
reviewed
Apr 30, 2026
…only) Replace the two-annotation design (auto-mnnvl + mnnvl-group) with a single grove.io/mnnvl-group annotation. Not backward compatible with Phase 1 — acceptable since the feature is still in alpha. Made-with: Cursor
shmuel-runai
force-pushed
the
grove-417/grep-single-annotation
branch
from
ab2f499 to
7ce688a
Compare
nvrohanv
reviewed
May 1, 2026
Contributor
nvrohanv
left a comment
nvrohanv
left a comment
There was a problem hiding this comment.
overall looks good, some small questions, will approve once addressed.
Co-authored-by: Cursor <cursoragent@cursor.com>
danbar2
previously approved these changes
May 3, 2026
Avoid confusion with reserved keywords — use a clearly user-defined group name in all GREP examples and tables. Co-authored-by: Cursor <cursoragent@cursor.com>
danbar2
previously approved these changes
May 6, 2026
gflarity
reviewed
May 9, 2026
Collaborator
sanjaychatterjee
left a comment
sanjaychatterjee
left a comment
There was a problem hiding this comment.
@shmuel-runai Thanks for the GREP. I am proposing to include the string "disabled" as a reserved string name, in addition to "none", to opt-out of MNNVL. Based on that, made a few suggestions.
nvrohanv
reviewed
May 12, 2026
Contributor
nvrohanv
left a comment
nvrohanv
left a comment
There was a problem hiding this comment.
got through first half will do second half tomorrow, looking good so far once @sanjaychatterjee's comments are addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind feature
Ref #417
Summary
auto-mnnvl+mnnvl-group) with a singlegrove.io/mnnvl-groupannotationKey changes from previous GREP
grove.io/mnnvl-groupcontrols both enrollment and group assignment"none"is the reserved opt-out value (replacesauto-mnnvl: disabled){pcs}-{replica}-{group}(single scheme)Test plan
Made with Cursor