feat: Add GREP-0376 for Volcano scheduler backend#560
Open
xianlubird wants to merge 2 commits into
Open
Conversation
Collaborator
|
@xianlubird Thanks for the GREP. I agree that targeting Volcano version 1.14+ is the right strategy. Overall the GREP looks good to me. I think it still needs more info regarding the TAS support. Please review PR #496 for the latest TAS updates in Grove. |
enoodle
reviewed
May 1, 2026
Contributor
enoodle
left a comment
There was a problem hiding this comment.
Looks really good, but I think we need to address this issue:
Signed-off-by: xianlubird <xianlubird@gmail.com>
00e2305 to
d552eca
Compare
kangclzjc
reviewed
May 1, 2026
kangclzjc
reviewed
May 1, 2026
sanjaychatterjee
previously approved these changes
May 1, 2026
Signed-off-by: xianlubird <xianlubird@gmail.com>
kangclzjc
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PodGroupsubGroupPolicyto map each Grove PodGang role into a Volcano subgroupPodCliqueSetto GrovePodGangto VolcanoPodGroupPodGroup.spec.subGroupPolicyKey design decisions
PodGangas the portable scheduler API and translate it to Volcano-native resources in the backendPodGroup.minReplicasto the corresponding VolcanosubGroupPolicy[].subGroupSizePodGroup.spec.minMembersubGroupPolicyis needed now, and future topology-aware scheduling will also depend on Volcano 1.14+ capabilitiesFixes #571