fix: edit_listing silent write loss — publish + verify after update

[asklepios-png]

Problem

edit_listing (MCP), torium listings edit (CLI), and ListingsAPI.set_price() reported success but the live listing never changed — silent write loss. The tool returned a fresh ETag, so the failure was invisible; in our case 64 edits were "made" that never existed.

Root cause

The adinput API is two-phase, like a draft email that is never sent:

1. PUT /adinput/ad/recommerce/{id}/update only stores a draft revision (this is why a new ETag is returned — the revision is real).
2. The live ad only changes after the commit step: GET productcontext?adRevision=X → POST /adinput/order/choices/{id} — the same completion sequence create() already uses.

The edit flow stopped after step 1 and inferred success from the ETag alone.

Verified live: a pending draft revision from a failed edit sat unpublished for 2 days; running the commit step published it. Also confirmed: the checkout-url (publish_free_ad?adRevision=...) returns 404 on POST — order/choices is the working commit path. Note that adview propagation after the commit takes minutes, not seconds.

Fix

• New ListingsAPI.edit(ad_id, price=…, title=…, description=…): update → publish (Basic, free) → read-back verification against adview (staggered ~5.5 min window). Raises RuntimeError instead of ever reporting an unverified success.
• update() now raises on meta-data validation violations (the API returns them with HTTP 200).
• MCP edit_listing and CLI listings edit routed through edit(); set_price() too.
• Editing an EXPIRED listing republishes it in the same call (same commit endpoint).
• CLI checkmark output made cp1252-safe (crashed on legacy Windows consoles).
• Regression tests (mocked client, no network): publish ordering, read-back mismatch, violation handling, whitespace normalization. Red-green verified against the old code.
• CONTEXT.md documents the root cause, live findings, and API behaviors (e.g. edited timestamp reflects revision creation time, not publish time).

Verified against a real account: a price change and 63 pending description revisions all published and read-back-verified.

🤖 Generated with Claude Code