Skip to content

feat(ziti): add debug service state#58

Open
casey-brooks wants to merge 3 commits into
mainfrom
noa/issue-57
Open

feat(ziti): add debug service state#58
casey-brooks wants to merge 3 commits into
mainfrom
noa/issue-57

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Add DebugServiceState handling to inspect a Ziti service by ID or name.
  • Return service roles, attached config JSON, service policies, and terminators for expose diagnostics.
  • Map missing services to gRPC NotFound.

Closes #57
Supports agynio/expose#27 and agynio/api#142.

Test & Lint Summary

  • nix shell nixpkgs#gcc --command sh -c 'go test ./... && go vet ./...': passed
  • git diff --check: passed

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • nix shell nixpkgs#gcc --command sh -c 'go test ./... && go vet ./...': passed
  • git diff --check: passed

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the debug-state endpoint. I found a contract mismatch that should be fixed before merge.

Comment thread internal/server/server.go Outdated
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Ready for re-review.

Updates after Noa's feedback:

  • DebugServiceState now resolves the explicit oneof service_identifier and errors when no identifier is set.
  • It no longer silently prefers one field over another; generated oneof semantics now make the active identifier explicit.

Test & Lint Summary

  • nix shell nixpkgs#gcc --command sh -c 'go test ./... && go vet ./...': passed
  • git diff --check: passed

noa-lucent
noa-lucent previously approved these changes May 29, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete. The DebugServiceState handler now switches on the generated oneof identifier and rejects missing/empty identifiers, so the previous contract mismatch is resolved.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Updated PR #58 to fix the CI stub-generation failure.

CI, Docker, and devspace now generate ziti-management protobuf stubs from the API debug branch (noa/ziti-debug-state) so DebugServiceState* symbols are present until agynio/api#142 is merged/published to BSR. This keeps the PR unblocked without committing generated .gen output.

Test & Lint Summary

  • nix shell nixpkgs#buf --command buf generate "https://github.com/agynio/api.git#branch=noa/ziti-debug-state,subdir=proto" --path agynio/api/ziti_management/v1: passed
  • nix shell nixpkgs#gcc --command sh -c 'go test ./... && go vet ./...': passed
  • git diff --check: passed

@rowan-stein

Copy link
Copy Markdown
Collaborator

Closing: debug service approach cancelled; no production debug interfaces.

@rowan-stein rowan-stein reopened this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ziti exposure debug state API

3 participants