Collapse sourceGuid/targetGuid to single-instance-pair shape - #197
Merged
Conversation
The CLI no longer supports multiple source/target instance pairs (or multiple standalone GUIDs) in a single run, so this removes the array/comma-parsing scaffolding built for that: sourceGuid/targetGuid go from string[] to string, apiKeys becomes two named fields, and push/pull/orchestrator loops collapse to a fixed source+target shape instead of an arbitrary GUID list. Hard cutover on the CLI flags: comma-separated --sourceGuid/--targetGuid now throws instead of silently using the first value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jules-exel
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state.sourceGuid/state.targetGuidgo fromstring[]tostring;state.apiKeysarray replaced withsourceApiKeys/targetApiKeys; deleted deadfinalizeAllGuidLoggers.push/pullorchestrators collapse to a fixed source+target shape instead of an arbitrary GUID list (removes the stale "future enhancement: handle multiple source/target combinations" TODO inorchestrate-pushers.ts, and the N-wayPromise.allSettledfan-out inorchestrate-downloaders.tsis now fixed at ≤2).--sourceGuid/--targetGuidnow throws a clear error instead of silently using the first value; dropped the pluralsourceGuids/targetGuidsaliases.someString[0]bugs in test seeders (e.g.model-pusher.test.ts) thattscdoesn't catch when narrowing an array field to a string.Test plan
tsc --noEmitclean on bothtsconfig.json(prod) andtsconfig.test.json(prod + tests)sourceGuid[0]/targetGuid[0]/.lengthusages outside intentional short-lived local arrays🤖 Generated with Claude Code