Review of terminal-detect, terminal-api, and terminal-tty at 859020a6 on 2026-09-28.
Review item: Design 4
Priority: P2
Evidence: Design work motivated by reproduced leaks, hangs, and routing failures.
Problem / scope
Borrowed standard streams, owned device descriptors, daemon readers,
executors, native arenas, and renderer writes currently use inconsistent
lifecycle rules. Some paths cannot detect EOF; others free resources before
reads finish or skip cleanup after restore failure.
Document these contracts and identify the smallest shared implementation
boundaries. This is coordination/design work over the linked concrete bugs,
not another request to fix them in one large change.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #335, #336, #337, #338, #341, #344, #311, #339.
Review of
terminal-detect,terminal-api, andterminal-ttyat 859020a6 on 2026-09-28.Review item: Design 4
Priority: P2
Evidence: Design work motivated by reproduced leaks, hangs, and routing failures.
Problem / scope
Borrowed standard streams, owned device descriptors, daemon readers,
executors, native arenas, and renderer writes currently use inconsistent
lifecycle rules. Some paths cannot detect EOF; others free resources before
reads finish or skip cleanup after restore failure.
Document these contracts and identify the smallest shared implementation
boundaries. This is coordination/design work over the linked concrete bugs,
not another request to fix them in one large change.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #335, #336, #337, #338, #341, #344, #311, #339.