Review of terminal-detect, terminal-api, and terminal-tty at 859020a6 on 2026-09-28.
Review item: Design 2
Priority: P2
Evidence: Cross-connection shared-state coupling confirmed in call paths.
Problem / scope
Every EventDecoder theme notification calls the process-global
TerminalCapabilities.onThemeChanged(). EventDecoder is also used for remote
SSH/Telnet/HTTP connections. A client's theme can therefore alter global local
defaults, and TerminalFeatures consults shared probe results for per-connection
mode answers. Startup defaults and an individual terminal's state need distinct
ownership.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #293, #292.
Review of
terminal-detect,terminal-api, andterminal-ttyat 859020a6 on 2026-09-28.Review item: Design 2
Priority: P2
Evidence: Cross-connection shared-state coupling confirmed in call paths.
Problem / scope
Every EventDecoder theme notification calls the process-global
TerminalCapabilities.onThemeChanged(). EventDecoder is also used for remote
SSH/Telnet/HTTP connections. A client's theme can therefore alter global local
defaults, and TerminalFeatures consults shared probe results for per-connection
mode answers. Startup defaults and an individual terminal's state need distinct
ownership.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #293, #292.