Review of terminal-detect, terminal-api, and terminal-tty at 859020a6 on 2026-09-28.
Review item: Design 1
Priority: P2
Evidence: Design work motivated by reproduced framing/routing defects.
Problem / scope
Standalone detection and TerminalFeatures independently frame/parse OSC/CSI
responses, while in-band queries temporarily replace the whole stdin handler.
The review found fragmentation, terminator, Escape, signal, and notification
routing failures. Define reusable protocol framing and per-query completion
without merging standalone I/O with an active connection reader.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #306, #307, #314, #315, #316, #317, #318, #345.
Review of
terminal-detect,terminal-api, andterminal-ttyat 859020a6 on 2026-09-28.Review item: Design 1
Priority: P2
Evidence: Design work motivated by reproduced framing/routing defects.
Problem / scope
Standalone detection and TerminalFeatures independently frame/parse OSC/CSI
responses, while in-band queries temporarily replace the whole stdin handler.
The review found fragmentation, terminator, Escape, signal, and notification
routing failures. Define reusable protocol framing and per-query completion
without merging standalone I/O with an active connection reader.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #306, #307, #314, #315, #316, #317, #318, #345.