Skip to content

Design an incremental terminal reply collector with explicit input routing #352

Description

@stalep

Review of terminal-detect, terminal-api, and terminal-tty at 859020a6 on 2026-09-28.

Review item: Design 1
Priority: P2
Evidence: Design work motivated by reproduced framing/routing defects.

Problem / scope

Standalone detection and TerminalFeatures independently frame/parse OSC/CSI
responses, while in-band queries temporarily replace the whole stdin handler.
The review found fragmentation, terminator, Escape, signal, and notification
routing failures. Define reusable protocol framing and per-query completion
without merging standalone I/O with an active connection reader.

Source at the reviewed commit

Acceptance criteria

  • Document the ownership boundary between user keys, unsolicited events, and pending query replies.
  • Reuse framing/completion where dependency direction permits; retain zero runtime dependencies in terminal-detect and Java 8 base support.
  • Plan small test-backed increments covering the linked defects, cancellation, and unrelated-input preservation; do not gate leaf fixes on a large rewrite.

Tracking

Part of #300. Related: #306, #307, #314, #315, #316, #317, #318, #345.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions