Review of terminal-detect, terminal-api, and terminal-tty at 859020a6 on 2026-09-28.
Review item: Performance 3
Priority: P2
Evidence: Repeated detector construction confirmed; end-to-end savings not measured.
Problem / scope
Full detection constructs a TerminalDetector, then detectPlatformTheme()
constructs another one instead of using the captured environment. On Windows
this can repeat registry-based terminal identity subprocesses. It also discards
the injected environment used by a caller/test detector.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #293, #297.
Review of
terminal-detect,terminal-api, andterminal-ttyat 859020a6 on 2026-09-28.Review item: Performance 3
Priority: P2
Evidence: Repeated detector construction confirmed; end-to-end savings not measured.
Problem / scope
Full detection constructs a TerminalDetector, then detectPlatformTheme()
constructs another one instead of using the captured environment. On Windows
this can repeat registry-based terminal identity subprocesses. It also discards
the injected environment used by a caller/test detector.
Source at the reviewed commit
Acceptance criteria
Tracking
Part of #300. Related: #293, #297.