Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

#[222] No info to user about invalid regex #253

Closed
Kabowyad wants to merge 17 commits into from
Closed

#[222] No info to user about invalid regex #253

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
51dcc95
issue-222 (No info to user about invalid regex):
Kabowyad Apr 4, 2019
2fb2903
issue-222:
Kabowyad Apr 4, 2019
4b25da4
issue-222:
Kabowyad Apr 4, 2019
8424a36
issue-222:
Kabowyad Apr 9, 2019
055491d
issue-222:
Kabowyad Apr 10, 2019
4fccd3a
issue-222:
Kabowyad Apr 18, 2019
06b1d8c
issue-222:
Kabowyad Apr 18, 2019
da623ec
issue-222:
Kabowyad Apr 18, 2019
43ea7c1
issue-222:
Kabowyad Jun 3, 2019
61bc938
Merge branch 'develop' into issue-222
Kabowyad Jun 3, 2019
0662fe1
Revert "Merge branch 'develop' into issue-222"
Kabowyad Jun 4, 2019
226c345
issue-222:
Kabowyad Jun 4, 2019
d1c9125
issue-222:
Kabowyad Jun 4, 2019
4fa55fa
issue-222:
Kabowyad Jun 29, 2019
5ae9c6c
issue-222:
Kabowyad Jun 29, 2019
9bcc0f6
issue-222:
Kabowyad Jun 30, 2019
71e262a
issue-222:
Kabowyad Jun 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions core/src/main/scala/codesearch/core/search/Search.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,13 @@ trait Search {
.toList
} yield CSearchPage(results.sortBy(_.pack.name), entity.lists.size, ErrorResponse(""))
}
case scala.util.Failure(exception) =>
{
val message = exception.getMessage
IO(CSearchPage(Seq.empty[Search.PackageResult], 0,
ErrorResponse(message.substring(0,1).toUpperCase + message.substring(1, message.size))))
}
case scala.util.Failure(exception) => {
Comment thread
Kabowyad marked this conversation as resolved.
Outdated
val message = exception.getMessage
IO(
CSearchPage(Seq.empty[Search.PackageResult],
0,
ErrorResponse(message.substring(0, 1).toUpperCase + message.substring(1, message.size))))
Copy link
Copy Markdown
Contributor

@kamilongus kamilongus May 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .lenght instead .size on strings.
You can make a more elegant code without .substring concatination.

Copy link
Copy Markdown
Member

@neongreen neongreen May 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .lenght instead .size on strings.

Does Scala have a linter that catches those things? (Also it's .length)

Copy link
Copy Markdown
Contributor

@kamilongus kamilongus May 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neongreen
Only IDE inspection support.
image
Or what did you mean?

Copy link
Copy Markdown
Member

@neongreen neongreen May 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant a linter that we can run during CI.

I have just tried to run SonarQube on our code, but it didn't find the message.size thing :(

}
}
}

Expand Down