Add IAU2000 selenoid#49
Merged
Merged
Conversation
Owner
Contributor
Author
lpsinger
force-pushed
the
iau2000-coordinates
branch
from
fd88610 to
092252b
Compare
Contributor
Author
|
Tests should be passing now. |
aelanman
approved these changes
May 11, 2026
aelanman
left a comment
aelanman
left a comment
Owner
There was a problem hiding this comment.
Looks good! I've made a note that the SPHERE selenoid should probably be removed in the future, and IAU2000 made the default.
|
|
||
|
|
||
| class SPHERESelenodeticRepresentation(BaseGeodeticRepresentation): | ||
| """Lunar ellipsoid as a sphere |
Owner
There was a problem hiding this comment.
I'm thinking we should deprecate this one, since the radius's source isn't documented and it's mostly equivalent to the IAU2000 definition (just with a radius 300 m smaller).
I'll make an issue to do that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3.