Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,25 @@ jobs:
- name: Lint
run: pnpm lint

test-types:
name: "Type Tests"
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: 22
cache: pnpm
- name: Install Dependencies
run: pnpm install --frozen-lockfile
- name: Build
run: pnpm build
- name: Test Types
run: pnpm --filter test-types test

test:
name: "Tests"
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/decorator-example1.gjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Component from '@glimmer/component';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';

@keyResponder
export default class DecoratorExample1 extends Component {
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/decorator-example2.gjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Component from '@glimmer/component';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';

@keyResponder
export default class DecoratorExample2 extends Component {
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/decorator-example3.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/* eslint-disable ember/no-classic-components */
import Component from '@ember/component';
import { computed } from '@ember/object';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';

export default keyResponder(
Component.extend({
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/decorator-example4.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/* eslint-disable ember/no-classic-classes */
/* eslint-disable ember/no-classic-components */
import Component from '@ember/component';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';

export default keyResponder(
Component.extend({
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/key-down-counter.gjs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Component from '@glimmer/component';
import { fn } from '@ember/helper';
import { on } from '@ember/modifier';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';
import { tracked } from '@glimmer/tracking';
import pick from '../helpers/pick.js';

Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/mouse-down-counter.gjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Component from '@glimmer/component';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';
import { tracked } from '@glimmer/tracking';

function makeEventHandler(stepSize = 1) {
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/on-key-helper-examples.gjs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Component from '@glimmer/component';
import { fn } from '@ember/helper';
import { tracked } from '@glimmer/tracking';
import onKey from '#src/helpers/on-key.js';
import onKey from '#src/helpers/on-key.ts';

function setTrue(obj, key) {
obj[key] = true;
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/on-key-modifier-examples.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { fn } from '@ember/helper';
import { on } from '@ember/modifier';
import { tracked } from '@glimmer/tracking';
import { action } from '@ember/object';
import onKeyModifier from '#src/modifiers/on-key.js';
import onKeyModifier from '#src/modifiers/on-key.ts';

export default class OnKeyModifierExamples extends Component {
@tracked bButtonTriggered = false;
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/touch-start-counter.gjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';

function makeEventHandler(stepSize = 1) {
return function (_event, ekEvent) {
Expand Down
2 changes: 1 addition & 1 deletion demo-app/components/trigger-event-widget.gjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Component from '@glimmer/component';
import { set } from '@ember/object';
import { keyResponder, onKey } from '#src/index.js';
import { keyResponder, onKey } from '#src/index.ts';

@keyResponder({ activated: true })
export default class TriggerEventWidget extends Component {
Expand Down
6 changes: 3 additions & 3 deletions demo-app/services/keyboard.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { action } from '@ember/object';
import { run } from '@ember/runloop';
import KeyboardService from '#src/services/keyboard.js';
import isKey from '#src/utils/is-key.js';
import { reverseCompareProp } from '#src/utils/sort.js';
import KeyboardService from '#src/services/keyboard.ts';
import isKey from '#src/utils/is-key.ts';
import { reverseCompareProp } from '#src/utils/sort.ts';

function handleKeyEventWithLaxPriorities(event, sortedResponders) {
let currentPriorityLevel;
Expand Down
22 changes: 19 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,32 @@
"#src/*": "./src/*"
},
"exports": {
".": "./dist/index.js",
".": {
"types": "./declarations/index.d.ts",
"default": "./dist/index.js"
},
"./*": {
"types": "./declarations/*.d.ts",
"default": "./dist/*.js"
},
"./test-support/key-event": "./dist/test-support/key-event.js",
"./test-support/test-helpers": "./dist/test-support/test-helpers.js",
"./test-support/key-event": {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in another PR, since we're preparing for a major -- we should just have test-support

"types": "./declarations/test-support/key-event.d.ts",
"default": "./dist/test-support/key-event.js"
},
"./test-support/test-helpers": {
"types": "./declarations/test-support/test-helpers.d.ts",
"default": "./dist/test-support/test-helpers.js"
},
"./addon-main.js": "./addon-main.cjs",
"./*.css": "./dist/*.css"
},
"typesVersions": {
"*": {
"*": [
"declarations/*"
]
}
},
"files": [
"addon-main.cjs",
"declarations",
Expand Down
39 changes: 39 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
packages:
- .
- docs
- test-types

allowBuilds:
core-js: false
Expand Down
101 changes: 0 additions & 101 deletions src/decorators/key-responder.js

This file was deleted.

Loading
Loading