docs(forms): adding forms strategy to washing machine workflow - #6584
docs(forms): adding forms strategy to washing machine workflow#6584aramos-adobe wants to merge 5 commits into
Conversation
|
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Coverage Report for CI Build 31039458154Warning No base build found for commit Coverage: 96.241%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
nikkimk
left a comment
There was a problem hiding this comment.
Thanks for taking this on. I have just a few change listed.
Description
Adds contributor-facing documentation for the approved 2nd-gen forms strategy so the decisions are discoverable before form-field migration PRs are opened.
CONTRIBUTOR-DOCS/03_project-planning/05_strategies/forms-strategy-rfc.md— the canonical forms strategy, mirroring the existingfocus-management-strategy-rfc.md. Covers ElementInternals/FACE form participation (FieldAssociationController), where ARIA roles live (shadow DOM), the label/help/error IDREF model (LabellingController, same-root slots + cross-root element references), a naming table, and the axe-core policy forElementInternalsgaps..../02_step-by-step/01_washing-machine-workflow.md— a new "Form participation (form fields only)" subsection in Phase 3 (API), label/help/error + cross-root IDREF guidance in Phase 4 (Accessibility), a Phase 4 axe/CI quality-gate item, a common-problems row, and a forms-strategy cross-link..../03_components/README.md— routes form-field migrations to the canonical strategy.Motivation and context
Form-field migration is about to scale, and the forms-strategy decisions previously lived only in a proof-of-concept repo and RFC discussion, not in the contributor docs. This surfaces them at the point migrators need them (Phase 3 and Phase 4 of the washing machine workflow) and gives every form field one canonical reference for form participation, role placement, cross-root labelling, and axe policy.
Content is sourced from the form-strategy proof-of-concept (
nikkimk/web-component-form-strategy-demos). Controllers still under an open research decision (ButtonAssociationController,RadioGroupController) are explicitly marked pending research rather than presented as settled.Related issue(s)
Screenshots (if appropriate)
N/A — Markdown contributor documentation only.
Author's checklist
CONTRIBUTOR-DOCSchanges are not published to a package.Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
New strategy doc and cross-links render correctly
CONTRIBUTOR-DOCS/03_project-planning/05_strategies/forms-strategy-rfc.md.TODOplaceholders.Washing machine workflow additions
.../02_step-by-step/01_washing-machine-workflow.md.Links resolve
CONTRIBUTOR-DOCS/01_contributor-guides/07_authoring-contributor-docs, runnode update-nav.js.Device review
Accessibility testing checklist
This PR changes Markdown contributor documentation only. It adds no component, runtime behavior, or focusable UI, so there is no interactive surface to test with a keyboard or screen reader.
Keyboard
Screen reader