Generate valid variable names from theme names and fix comma in output formatting - #243
Conversation
|
Run report for 7b14f3a7Total time: 19s | Comparison time: 17.6s | Estimated loss: 1.3s (7.1% slower)
Touched files |
|
@thierryc I'm trying to test this locally, but I'm not sure it's working. Running locally, I created a new theme and changed the name to something with spaces. Looking at the URL with the string of data, it converted it the spaces to Do you have an example of some data that should be escaped and what it should look like after going through your regex? |
7b14f3a to
8b69dd7
Compare
Description
Just cleaning up #223 on a new branch/pr.
Motivation
thierryc made a great pr but we've made some big structural changes since then.
To-do list