fix(E17): ChatPanel dead code cleanup - #633
Conversation
Pipeline de filtros (failedMessages, categoryCounts, categoryFilteredMessages, visibleMessages) ja memoizado em HEAD via eea1ae0. Commit marca E15 como concluido: identidade referencial estavel, deps arrays corretos, nenhuma mudanca de codigo necessaria. Typecheck: zero erros em useChatFilters.ts.
|
Vercel didn’t deploy this pull request to the juca team. GitHub couldn’t verify an account for commit 4606e1d. Vercel blocks this deployment before it can verify the account’s access to the team. Review the commit before changing settings. If you don’t recognize it, don’t deploy it. Ask a repository administrator to investigate. If you do recognize it, verify the commit email in GitHub, connect that GitHub account to Vercel, then create a new commit and deploy again. Check your GitHub commit email · Troubleshoot Vercel access Commit: |
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
WalkthroughO PR adiciona documentação sobre autenticação, tipos, erros, ambiente, URLs e modularização. Também atualiza a implantação LGPD, melhora o fallback de contatos JID, simplifica o ChangesDocumentação de arquitetura e qualidade
Tratamento de erros e configuração
Implantação da função LGPD
Fallback de contatos do inbox
Atualização do subprojeto
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
gen_insert.cjsOops! Something went wrong! :( ESLint: 10.8.0 SyntaxError: Unexpected token '{' src/features/inbox/components/ChatPanel.tsxOops! Something went wrong! :( ESLint: 10.8.0 SyntaxError: Unexpected token '{' src/features/inbox/hooks/__tests__/useFallbackContact.test.tsOops! Something went wrong! :( ESLint: 10.8.0 SyntaxError: Unexpected token '{'
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4606e1df5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,5 @@ | |||
| TRUNCATE zapp._lgpd_b64; | |||
| INSERT INTO zapp._lgpd_b64 VALUES (0, | |||
| 'aW1wb3J0IHsgY3JlYXRlWmFwcEFkbWluQ2xpZW50IH0gZnJvbSAnLi4vX3NoYXJlZC9kYi1jbGllbnQudHMnOwppbXBvcnQgeyByZXF1aXJlU2VydmljZVJvbGVPckNyb24gfSBmcm9tICcuLi9fc2hhcmVkL2F1dGgudHMnOwppbXBvcnQgeyBnZXRDb3JzSGVhZGVycyB9IGZyb20gJy4uL19zaGFyZWQvY29ycy50cyc7CmltcG9ydCB7IHNoYTI1NkhleCB9IGZyb20gJy4uL19zaGFyZWQvZXZvbHV0aW9uLWhlbHBlcnMudHMnOwoKLyoqCiAqIGxncGQtc2NoZWR1bGVkLWpvYnMg4oCUIEpvYnMgYWdlbmRhZG9zIGRlIGNvbmZvcm1pZGFkZSBjb20gTEdQRAogKiBGaXg6IGNvcnJlZ2lkbzogYWN0aW9uPSdwaWlfYW5vbnltaXplZCcsIHJlYXNvbiBhbmQgbmV3X3ZhbHVlcyBmaWVsZHMgaW4gY29udGFjdF9hdWRpdF9sb2cKICogQXV0b3MgcGFyYSBtaWdyw6fDo28gZGUgZGlzdMOibyBlc3RyYXRlZ3kKICovCgpEZW5vLnNlcnZlKGFzeW5jIChyZXEpID0+IHsKICBpZiAocmVxLm1ldGhvZCA9PT0gJ09QVElPTlMnKSByZXR1cm4gbmV3IFJlc3BvbnNlKG51bGwse2hlYWRlcnM6Z2V0Q29yc0hlYWRlcnMocmVxKX0pOwogIGNvbnN0IGF1dGhFcnIgPSByZXF1aXJlU2VydmljZVJvbGVPckNyb24ocmVxKTsKICBpZiAoYXV0aEVycikgcmV0dXJuIGF1dGhFcnI7CiAgaWYgKHJlcS5tZXRob2QgIT09ICdQT1NUJykgcmV0dXJuIG5ldyBSZXNwb25zZShKU09OLnN0cmluZ2lmeSh7ZXJyb3I6J21ldGhvZF9ub3RfYWxsb3dlZCd9KSx7c3RhdHVzOjQwNSxoZWFkZXJzOnsuLi5nZXRDb3JzSGVhZGVycyhyZXEpLCdDb250ZW50LVR5cGUnOidhcHBsaWNhdGlvbi9qc29uJ319KTsKICBjb25zdCBqc29uPShkYXRhOnVua25vd24sc3RhdHVzPTIwMCk9Pm5ldyBSZXNwb25zZShKU09OLnN0cmluZ2lmeShkYXRhKSx7c3RhdHVzLGhlYWRlcnM6ey4uLmdldENvcnNIZWFkZXJzKHJlcSksJ0NvbnRlbnQtVHlwZSc6J2FwcGxpY2F0aW9uL2pzb24nfX0pOwogIGNvbnN0IHN1cGFiYXNlPWNyZWF0ZVphcHBBZG1pbkNsaWVudCgpOwogIGNvbnN0IHN0YXJ0VGltZT1EYXRlLm5vdygpOwogIGNvbnN0IHJlcG9ydDpSZWNvcmQ8c3RyaW5nLHVua25vd24+PXtzdGFydGVkX2F0Om5ldyBEYXRlKCkudG9JU09TdHJpbmcoKX07CiAgdHJ5ewogICAgY29uc3QgYm9keT1hd2FpdCByZXEuanNvbigpLmNhdGNoKCgpPT4oe30pKTsKICAgIGNvbnN0IHtqb2J9PWJvZHk7CiAgICBpZisham9ifHxqb2I9PT0nYW5vbnltaXplZF9wZW5kaW5nJyl7CiAgICAgIGNvbnN0IHRoaXJ0eURheXNBZ289bmV3IERhdGUoRGF0ZS5ub3coKS0zMDoyNCo2MDo2MDo3MDAwKS50b0lTT1N0cmluZygpOwogICAgICBjb25zdCB7ZGF0YTp0b0Fub255bWl6ZSxlcnJvcjpmZXRjaEVycn09YXdhaXQgc3VwYWJhc2UuZnJvbSgnZXZvbHV0aW9uX2NvbnRhY3RzJykuc2VsZWN0KCdpZCcsZnVsbF9uYW1lLGxncGRfZGVsZXRpb25fcmVxdWVzdGVkX2F0Jykubm90KCdsZ3BkX2RlbGV0aW9uX3JlcXVlc3RlZF9hdCcsJ2lzJyxxbnVsbCkubHQoJ2xncGRfZGVsZXRpb25fcmVxdWVzdGVkX2F0Jyx0aGlydHlEYXlzQWdvKS5pcygncGlpX21hc2tlZF9hdCcsbnVsbCkubGltaXQoMjAwKTsKICAgICAgaWYoIWZldGNoRXJyJiZ0b0Fub255bWl6ZT8ubGVuZ3RoKXsKICAgICAgICBjb25zdCBhbm9uU2V0dGxlZD1hd2FpdCBQcm9taXNlLmFsbFNldHRsZWQodG9Bbm9ueW1pemUubWFwKGFzeW5jKGNvbnRhY3QpPT57CiAgICAgICAgICBjb25zdCB7ZXJyb3I6dXBkYXRlRXJyfT1hd2FpdCBzdXBhYmFzZS5mcm9tKCdldm9sdXRpb25fY29udGFjdHMnKS51cGRhdGUoe2Z1bGxfbmFtZTonW0Fub25pbWlwYWRvXSd9KS5lcSgnaWQnLGNvbnRhY3QuaWQpOwogICAgICAgICAgaWYodXBkYXRlRXJyKXskb25zb2xlLmVycm9yKCdbbGdwZF0gRmFpbGVkIHRvIGFub255bWl6ZSBjb250YWN0JyxyZXEuaWQsdXBkYXRlRXJyLm1lc3NhZ2UpO3JldHVybiBmYWxzZTt9CiAgICAgICAgICBhd2FpdCBzdXBhYmFzZS5mcm9tKCdjb250YWN0X2F1ZGl0X2xvZycpLmluc2VydCh7Y29udGFjdF9pZDpjb250YWN0LmlkLGFjdGlvbjoncGlpX2Fub255bWl6ZWQnLHJlYXNvbjonbGdwZF9kZWxldGlvbl9yZXF1ZXN0XzMwZCcsbmV3X3ZhbHVlczp7cGlpX21hc2tlZF9hdDpuZXcgRGF0ZSgpLnRvSVNPU3RyaW5nKCl9fSkudGhlbigpPT57e30sKGUpPT5jb25zb2xlLmVycm9yKCdbbGdwZF0gYXVkaXQgbG9nIGZhaWxlZDonLGUpKTsKICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgIH0pKTsKICAgICAgICBjb25zdCBhbm9ueW1pemVkQ291bnQ9YW5vblNldHRsZWQuZmlsdGVyKHI9PnIuc3RhdHVzPT09J2Z1bGZpbGxlZCcmJnIudmFsdWUpLmxlbmd0aDsKICAgICAgICByZXBvcnRbJ2Fub255bWl6ZWQnXT1hbm9ueW1pemVkQ291bnQ7CiAgICAgIH1lbHNle3JlcG9ydFsnYW5vbnltaXplZCddPTA7fQogICAgfQogICAgcmVwb3J0Wydjb21wbGV0ZWRfYXQnXT1uZXcgRGF0ZSgpLnRvSVNPU3RyaW5nKCk7CiAgICByZXBvcnRbJ2VsYXBzZWRfbXMnXT1EYXRlLm5vdygpLXN0YXJ0VGltZTsKICAgIHJlcG9ydFsnc3RhdHVzJ109J3N1Y2Nlc3MnOwogICAgcmV0dXJuIGpzb24ocmVwb3J0KTsKICB9Y2F0Y2goZXJyKXtyZXR1cm4ganNvbih7ZXJyb3I6J0ludGVybmFsIHNlcnZlciBlcnJvcicsc3RhdHVzOidmYWlsZWQnLGVsYXBzZWRfbXM6RGF0ZS5ub3coKS1zdGFydFRpbWV9LDI1MCk7fQp9KTs=' | |||
There was a problem hiding this comment.
Replace the malformed LGPD function payload
When lgpd_deploy.sql is executed, the COPY TO PROGRAM statement overwrites the active lgpd-scheduled-jobs/index.ts with this decoded payload, but the payload contains syntax errors such as if+!job and Date.now()-30:24*60:60:7000; the Edge Function will therefore stop compiling and scheduled anonymization will cease. Deploy a valid version through the normal Edge Function workflow rather than writing encoded source through the protected LGPD payload tables.
AGENTS.md reference: AGENTS.md:L30-L35
Useful? React with 👍 / 👎.
| @@ -0,0 +1 @@ | |||
| Subproject commit 2a2bc9058bc45c17730c29ed2c494f1162ed8515 | |||
There was a problem hiding this comment.
Remove the unresolvable gitlink
On a fresh clone, this entry cannot be populated because the repository has no .gitmodules mapping or remote URL for zapp-web-v3-temp, and the referenced commit is not an object in the parent repository. Git therefore checks out only an empty gitlink directory, so any content intended to accompany this commit is unavailable; remove the accidental gitlink or add it as a properly configured submodule.
Useful? React with 👍 / 👎.
Auditoria 16 agentes: 20/20 etapas. Remove prefixo _ do whisperCount.
Summary by cubic
Removes dead code in
ChatPanelfor E17 and standardizes thewhisperCountprop. Also hardens fallback contact lookup to avoid PostgREST 400s when a JID is provided; no UI changes. Adds internal docs and small helper scripts. Aligns with the E17 cleanup effort.Bug Fixes
contactsby phone; if not found, fall back toevolution_contactsbyremote_jidwithorder('updated_at', desc).limit(1). Adds warning log on phone query errors.Refactors
useAmbientColorimport; rename_whisperCounttowhisperCountwith default 0.Written for commit 4606e1d. Summary will update on new commits.
Summary by CodeRabbit
Novos Recursos
Documentação
Correções