feat: add take_error to responses and expand HttpResponse conversions#4041
Open
iamfaiz123 wants to merge 2 commits intoactix:mainfrom
Open
feat: add take_error to responses and expand HttpResponse conversions#4041iamfaiz123 wants to merge 2 commits intoactix:mainfrom
iamfaiz123 wants to merge 2 commits intoactix:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
This PR enhances the
HttpResponseandServiceResponseAPIs by adding atake_error()method and expanding available type conversions.Changes:
take_error()Method: Added to bothHttpResponseandServiceResponse. This allows callers (particularly middleware) to take ownership of the innerError, leavingNonein its place.HttpResponseConversions: AddedFromimplementations forHttpResponsefrom common types includingString,&String,Vec<u8>,&Vec<u8>,Bytes, andByteString.ServiceRequest::into_responseFlexibility: Updated to acceptInto<HttpResponse<B>>instead ofInto<Response<B>>, providing better ergonomics when converting requests to responses.response.rsandservice.rsto verify thattake_error()correctly extracts the error and leaves the response state consistent.Issues:
Breaking Changes:
ServiceRequest::into_responsefromInto<Response<B>>toInto<HttpResponse<B>>is a minor breaking change for any custom types implementingInto<Response<B>>but notInto<HttpResponse<B>>.