fix(http,web): correctly drop web::Data on graceful shutdown#4033
Open
JohnTitor wants to merge 1 commit intoactix:mainfrom
Open
fix(http,web): correctly drop web::Data on graceful shutdown#4033JohnTitor wants to merge 1 commit intoactix:mainfrom
web::Data on graceful shutdown#4033JohnTitor wants to merge 1 commit intoactix:mainfrom
Conversation
JohnTitor
force-pushed
the
web-data-drop
branch
2 times, most recently
from
98ab19e to
fc0b5ef
Compare
JohnTitor
force-pushed
the
web-data-drop
branch
from
fc0b5ef to
c4c93af
Compare
JohnTitor
force-pushed
the
web-data-drop
branch
from
c4c93af to
d278574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
PR_TYPE
PR Checklist
Overview
Fix #3100
Fixes a
web::Dataleak during graceful shutdown when requst is still sending a slow request body.I think the leak happened because a late-dropping
HttpRequestcould return itself toHttpRequestPoolafterAppInitServicehad already been dropped. That could keep application data alive indefinitely.This disables the request pool when
AppInitServiceis dropped. It also wakes HTTP/1 payload receivers with an incomplete-payload error when their sender is dropped before EOF, so body readers do not stay pending during shutdown.