Skip to content

test(multipart,derive): move trybuild tests#4028

Open
JohnTitor wants to merge 1 commit intoactix:mainfrom
JohnTitor:multipart-derive-test-move
Open

test(multipart,derive): move trybuild tests#4028
JohnTitor wants to merge 1 commit intoactix:mainfrom
JohnTitor:multipart-derive-test-move

Conversation

@JohnTitor
Copy link
Copy Markdown
Member

PR Type

PR_TYPE

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

To avoid cyclic dependency tree.

@github-actions github-actions Bot added A-multipart project: actix-multipart A-multipart-derive project: A-actix-multipart-derive labels Apr 17, 2026
@JohnTitor
Copy link
Copy Markdown
Member Author

@robjtede By the way, could you add me as owner of multipart-derive?

@JohnTitor JohnTitor force-pushed the multipart-derive-test-move branch from c37d39a to c69afd4 Compare April 17, 2026 17:50
@robjtede
Copy link
Copy Markdown
Member

@JohnTitor 👍🏻 added the core team as owners

@robjtede
Copy link
Copy Markdown
Member

i dont love this solution, disabling doctests etc, and i think there's a better way of avoiding it during publishes, testing now...

@JohnTitor
Copy link
Copy Markdown
Member Author

JohnTitor commented Apr 18, 2026

@robjtede
In practice, I don't think it makes a big difference though. If the derive crate is meant to be used along with the base crate, that doc should be live there, I think. How about moving docs to the main crate and putting a link on the derive side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-multipart project: actix-multipart A-multipart-derive project: A-actix-multipart-derive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants