feat: add ability to specify log level for access logger#3157
Closed
tglman wants to merge 4 commits intoactix:masterfrom
Closed
feat: add ability to specify log level for access logger#3157tglman wants to merge 4 commits intoactix:masterfrom
tglman wants to merge 4 commits intoactix:masterfrom
Conversation
e93e3f7 to
7c80804
Compare
Contributor
Author
|
Hi, This is complete also, it may conflict with the pr: #3086 because it add the same deps for test the logs, I may rebase the one of the two pr based on the one that is merged before. Regards |
7c80804 to
42f1c6b
Compare
Member
|
Thanks for the work you've put into this. I'm planning on migrating all the actix/* codebases over to We can revisit this idea after the tracing migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This add a new feature to the
Loggermiddleware to set the level of the log.Example
Logger::default().level(Level::Debug);This would ideally go together with #3086
PR Checklist