fix: use env var indirection for inputs.include-hidden-files (CMD_EXEC)#141
Open
nbuckwalt wants to merge 1 commit intoactions:mainfrom
Open
fix: use env var indirection for inputs.include-hidden-files (CMD_EXEC)#141nbuckwalt wants to merge 1 commit intoactions:mainfrom
nbuckwalt wants to merge 1 commit intoactions:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the composite GitHub Action to mitigate a GitHub Actions expression injection vector (CMD_EXEC) by removing direct interpolation of inputs.include-hidden-files into shell commands and instead evaluating it via an environment variable in the shell.
Changes:
- Replaced
${{ ... }}expression interpolation inrun:with a shell conditional based onINCLUDE_HIDDEN_FILES. - Added
INCLUDE_HIDDEN_FILEStoenv:for each platform-specific “Archive artifact” step (Linux/macOS/Windows).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: CMD_EXEC via inputs.include-hidden-files
Summary
`inputs.include-hidden-files` is directly interpolated into the `run:` shell command across all three "Archive artifact" steps (Linux/macOS/Windows variants):
```
${{ inputs.include-hidden-files != 'true' && '--exclude=.[^/]*' || '' }}
```
A caller passing a crafted value could inject arbitrary shell arguments or commands into the `tar` invocation.
Fix
Map the input to an `env:` variable (`INCLUDE_HIDDEN_FILES`) and evaluate the condition in shell using `[ "$INCLUDE_HIDDEN_FILES" != 'true' ]`. Applied to all three platform-specific steps. Behavior is identical.
References
🤖 Generated with Claude Code