Skip to content

Update upload-artifact action to version 7#139

Merged
tsusdere merged 4 commits intoactions:mainfrom
Tom-van-Woudenberg:patch-1
Apr 8, 2026
Merged

Update upload-artifact action to version 7#139
tsusdere merged 4 commits intoactions:mainfrom
Tom-van-Woudenberg:patch-1

Conversation

@Tom-van-Woudenberg
Copy link
Copy Markdown
Contributor

@Tom-van-Woudenberg Tom-van-Woudenberg commented Mar 11, 2026 •
edited
Loading

@Tom-van-Woudenberg Tom-van-Woudenberg requested a review from a team as a code owner March 11, 2026 15:17
Copilot AI review requested due to automatic review settings March 11, 2026 15:17
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the internal dependency used by this composite action to upload artifacts, aligning with GitHub Actions runner runtime changes related to the deprecation of Node 20.

Changes:

  • Update actions/upload-artifact reference from a pinned v4.6.2 commit SHA to @v7.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xgboosted
Copy link
Copy Markdown

xgboosted commented Mar 13, 2026

Please approve this PR.

actions/upload-artifact@v6 started to support node24, though v7 is preferred as it is latest.

@martincostello
Copy link
Copy Markdown
Contributor

martincostello commented Mar 14, 2026

@salmanmkc another here one to go with actions/deploy-pages#404 and actions/configure-pages#186

@snelusha snelusha mentioned this pull request Mar 19, 2026
Merged
martincostello
martincostello reviewed Mar 25, 2026
View reviewed changes
salmanmkc
salmanmkc approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown

@salmanmkc salmanmkc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha looks good, I can't merge but stamping

@Tom-van-Woudenberg @martincostello
Update action.yml
57f0e84 
Co-authored-by: Martin Costello <martin@martincostello.com>
@Tom-van-Woudenberg Tom-van-Woudenberg mentioned this pull request Mar 26, 2026
Closed
@kingthorin
Copy link
Copy Markdown

kingthorin commented Mar 26, 2026

It seems I accidentally duplicated this PR in #140.

It would be really great to get this in: In order to be ready for the June Node 20 actions deprecation.

Ex:

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: 
actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e. 
Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. 
Please check if updated versions of these actions are available that support Node.js 24. 
To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment 
variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily 
opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. 
For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

@charliek charliek mentioned this pull request Apr 1, 2026
Merged
2 tasks
Rabadash8820
Rabadash8820 approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

@Rabadash8820 Rabadash8820 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that my approval won't mean anything but...I also approve. 😅

@Rabadash8820 Rabadash8820 mentioned this pull request Apr 1, 2026
Closed
@Rabadash8820
Copy link
Copy Markdown

Rabadash8820 commented Apr 1, 2026 •
edited
Loading

@Tom-van-Woudenberg You could edit this PR description to include "Fixes #138" so that that Issue gets closed when this PR is merged 👍

@Rabadash8820
Copy link
Copy Markdown

Rabadash8820 commented Apr 1, 2026

@jonchurch @heavymachinery @tsusdere @KittyChiu

Sorry for the disturbance, folks, but you all were the most recent/active Contributors to this repo, so I'm hoping that one of you can merge this PR, or ping someone who can. 🙏

@mpurnell1
Copy link
Copy Markdown

mpurnell1 commented Apr 2, 2026

Looks like @Rabadash8820 may have accidentally tagged the people who authored the recently merged commits/PRs instead of the maintainers who actually approved and merged them. @tsusdere @TooManyBees @yoannchaudet would any of you be able to help get this PR approved and merged?

tednaleid added a commit to tednaleid/limn that referenced this pull request Apr 4, 2026
@tednaleid @claude
Bump upload-pages-artifact v3 to v4
5e021c6 
Node.js 20 deprecation warning from its internal upload-artifact@v4.6.2
dependency remains until upstream merges actions/upload-pages-artifact#139.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tednaleid added a commit to tednaleid/limn that referenced this pull request Apr 4, 2026
@tednaleid @claude
Force Node 24 in deploy workflow to suppress deprecation warning
4f12c54 
upload-pages-artifact@v4 internally uses upload-artifact@v4.6.2 which
targets Node 20. Upstream fix pending (actions/upload-pages-artifact#139).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@murillodominguez murillodominguez mentioned this pull request Apr 5, 2026
Merged
@kingthorin kingthorin mentioned this pull request Apr 8, 2026
Merged
tsusdere
tsusdere approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tsusdere tsusdere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing from the Pages team!

@tsusdere tsusdere enabled auto-merge April 8, 2026 18:26
@kingthorin
Copy link
Copy Markdown

kingthorin commented Apr 8, 2026 •
edited
Loading

@tsusdere I think you have to merge manually since it's out-of-date?

@dylanmtaylor
Copy link
Copy Markdown

dylanmtaylor commented Apr 8, 2026

@tsusdere I think you have to merge manually since it's out-of-date?

It does say Changes can be cleanly merged, so should just be a matter of unchecking auto merge and clicking the merge button

@joapuiib
Copy link
Copy Markdown

joapuiib commented Apr 8, 2026 •
edited
Loading

Or maybe @Tom-van-Woudenberg needs to merge the main branch back to patch-1 branch to update it.

@tsusdere tsusdere merged commit fc324d3 into actions:main Apr 8, 2026
6 checks passed
@kingthorin
Copy link
Copy Markdown

kingthorin commented Apr 9, 2026

@tsusdere are you also able to do a release of the action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@tsusdere tsusdere tsusdere approved these changes

+8 more reviewers

@martincostello martincostello martincostello left review comments

@28Pollux28 28Pollux28 28Pollux28 left review comments

@ulgens ulgens ulgens approved these changes

@dylanmtaylor dylanmtaylor dylanmtaylor approved these changes

@Rabadash8820 Rabadash8820 Rabadash8820 approved these changes

@salmanmkc salmanmkc salmanmkc approved these changes

@vyndrix vyndrix vyndrix approved these changes

@biehlermi biehlermi biehlermi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node.js 20 actions are deprecated (actions/upload-artifact@v4.6.2)