feat(mcp): per-call reconsolidate opt-out makes smem_recall a read-only probe when asked - #235
Merged
Merged
Conversation
…ly probe when asked Recall writes by design — deferred-write flush (fiber conductivity, Hebbian strengthening) plus reconsolidation of the top five matched fibers — but that contract lived only in retrieval.py, invisible to speculative tool callers. smem_recall now accepts reconsolidate (bool, default true), threaded through ReflexPipeline.query alongside the per-brain reconsolidation_enabled switch, and the guide documents the write-by-design behaviour plus both switches. Closes #198
acidkill
force-pushed
the
feat/recall-read-only-probe
branch
from
September 7, 2026 15:51
b7ac3fa to
fc4f9e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smem_recallgains areconsolidateargument (boolean, defaulttrue), threaded throughReflexPipeline.query—falseskips post-recall reconsolidation for that invocation only.docs/guides/mcp-server.mdgains a "Recall writes by design" section: the deferred-write flush and reconsolidation behaviour, the per-brainreconsolidation_enabledswitch, and when speculative callers should passfalse.Why
Closes #198. Recall is a writing operation (conductivity flush + top-5 reconsolidation) gated by a per-brain switch that agent harnesses calling the MCP tool speculatively several times per turn cannot see or scope per call. The docs make the contract findable where callers look; the per-call opt-out gives a genuinely read-only probe without taking the global behaviour away from anyone.
Test plan
pytest tests/ -m "not stress" -n auto— 7344 passed (4 new: default True threads through, explicit False threads through, non-boolean rejected, engine signature contract).ruff check/ruff format --checkclean;mypy— only the pre-existing google.genai attr-defined noise.reconsolidatedocumented in the input schema).Verified by
@acidkill