Feature skip plugins mid run - #1829
Open
Abu-Huraira21 wants to merge 22 commits into
Open
Conversation
- Add dedicated _skip_handler for SIGUSR1/SIGUSR2 signals - These signals always skip current plugin without abort risk - Can be sent externally via: kill -USR1 <pid> or kill -USR2 <pid> - Only registered on Unix-like systems (where available)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds --mp_per_plugin, an opt-in flag that runs each plugin in its own subprocess instead of the main process. Default
behavior (no flag) is unchanged.
Problem: a single hung/stuck plugin blocks the entire run with no way to recover short of killing the process.
Fix: with --mp_per_plugin, each plugin runs in a spawned subprocess. If one hangs:
Files changed
Known issue (not fixed by this PR)
Encrypted iTunes backups can fail to open the decrypted Manifest.db with unable to open database file — pre-existing,
unrelated to this change. Root cause: Manifest.db is WAL-mode, and open_sqlite_db_readonly() has no fallback for opening
WAL-mode DBs missing their -wal/-shm sidecar files. Reproducible on current main independent of --mp_per_plugin. Will
follow up with a separate PR (immutable=1 retry fix).
Testing
Verified --mp_per_plugin end-to-end against an iTunes backup extraction, including plugin skip via Ctrl+C and SIGUSR1.
Notes: