Skip to content

[ECO-5208] Support laravel 12 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sacOO7 merged 2 commits into from
Feb 26, 2025
Merged

[ECO-5208] Support laravel 12 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
308c30e
[ECO-5208] Updated default token expiry
sacOO7 Feb 19, 2025
b2e643b
[ECO-5208] Updated composer.json and github workflow file
sacOO7 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: [7.2, 7.3, 7.4, 8.0, 8.1, 8.2]
laravel-version: [6.*, 7.*, 8.*, 9.*, 10.*, 11.*]
php-version: [7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3, 8.4]
laravel-version: [6.*, 7.*, 8.*, 9.*, 10.*, 11.*, 12.*]
include:
- laravel-version: 6.*
testbench: 4.*
Expand All @@ -31,8 +31,20 @@ jobs:
testbench: 8.*
- laravel-version: 11.*
testbench: 9.*
- laravel-version: 12.*
testbench: 10.*

exclude:
- laravel-version: 12.*
php-version: 7.2
- laravel-version: 12.*
php-version: 7.3
- laravel-version: 12.*
php-version: 7.4
- laravel-version: 12.*
php-version: 8.0
- laravel-version: 12.*
php-version: 8.1
- laravel-version: 11.*
php-version: 7.2
- laravel-version: 11.*
Expand Down Expand Up @@ -67,6 +79,14 @@ jobs:
php-version: 8.2
- laravel-version: 7.*
php-version: 8.2
- laravel-version: 6.*
php-version: 8.3
- laravel-version: 7.*
php-version: 8.3
- laravel-version: 6.*
php-version: 8.4
- laravel-version: 7.*
php-version: 8.4

name: P${{ matrix.php-version }} - L${{ matrix.laravel-version }}

Expand Down
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,11 @@ npm run dev
],
```

**3. Update token expiry. Default: 3600 seconds (1 hr)**
**3. Update token expiry. Default: 28800 seconds (8 hrs)**
- Default expiry set to 8 hrs in order to reduce CPU workload for auth requests. Check [discussion](https://github.com/ably/laravel-broadcaster/issues/55#issuecomment-2582845145).
- Set `ABLY_TOKEN_EXPIRY` in **.env** file.
```dotenv
ABLY_TOKEN_EXPIRY=21600
ABLY_TOKEN_EXPIRY=43200
Comment thread
sacOO7 marked this conversation as resolved.
```
- Update ably section under `config/broadcasting.php` with
```php
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
"require": {
"php": "^7.2 || ^8.0",
"ably/ably-php": "^1.1",
"illuminate/support": "^6.0 || ^7.0 || ^8.0 || ^9.0 || ^10.0 || ^11.0",
"illuminate/support": "^6.0 || ^7.0 || ^8.0 || ^9.0 || ^10.0 || ^11.0 || ^12.0",
Comment thread
AndyTWF marked this conversation as resolved.
"ext-json" : "*"
},
"require-dev": {
"phpunit/phpunit": "^8.5 || ^9.5 || ^10.0 || ^11.0",
"orchestra/testbench": "4.* || 8.* || 9.*"
"phpunit/phpunit": "^8.5 || ^9.5 || ^10.0 || ^11.0 || ^12.0",
"orchestra/testbench": "4.* || 8.* || 9.* || 10.*"
},
"autoload": {
"psr-4": {
Expand Down
4 changes: 2 additions & 2 deletions src/AblyBroadcaster.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ class AblyBroadcaster extends Broadcaster
* Used for setting expiry of issues tokens.
*
* @var int|mixed
* @default 1 hr
* @default 8 hr
*/
private $tokenExpiry = 3600;
private $tokenExpiry = 28800;

/**
* Public channel capabilities. By default, all public channels are given subscribe, history and channel-metadata access.
Expand Down